Add deprecation to Http2StreamChannelBootstrap.open0(...) as it was m…#9372
Merged
normanmaurer merged 1 commit into4.1from Jul 16, 2019
Merged
Add deprecation to Http2StreamChannelBootstrap.open0(...) as it was m…#9372normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
…arked as public by mistake Motivation: Mark Http2StreamChannelBootstrap.open0(...) as deprecated as the user should not use it. It was marked as public by mistake. Modifications: Add deprecation warning. Result: User will be aware the method should not be used directly.
njhill
approved these changes
Jul 15, 2019
Member
njhill
left a comment
There was a problem hiding this comment.
LGTM though I'm not a direct consumer of this API so may not understand all the implications.
ejona86
approved these changes
Jul 15, 2019
normanmaurer
added a commit
that referenced
this pull request
Jul 16, 2019
…arked as public by mistake (#9372) Motivation: Mark Http2StreamChannelBootstrap.open0(...) as deprecated as the user should not use it. It was marked as public by mistake. Modifications: Add deprecation warning. Result: User will be aware the method should not be used directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arked as public by mistake
Motivation:
Mark Http2StreamChannelBootstrap.open0(...) as deprecated as the user should not use it. It was marked as public by mistake.
Modifications:
Add deprecation warning.
Result:
User will be aware the method should not be used directly.