Cleanup in websockets, throw exception before allocating response if…#9361
Merged
normanmaurer merged 4 commits intonetty:4.1from Jul 16, 2019
doom369:clenaup_websockets
Merged
Cleanup in websockets, throw exception before allocating response if…#9361normanmaurer merged 4 commits intonetty:4.1from doom369:clenaup_websockets
normanmaurer merged 4 commits intonetty:4.1from
doom369:clenaup_websockets
Conversation
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
Contributor
Author
|
@normanmaurer are you aware of this error:
? |
… possible, one more fix for WebSocketClientHandshaker
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
Jul 15, 2019
slandelle
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… possible
Motivation:
While fixing #9359 found few places that could be patched / improved separately.
Modification:
On handshake response generation - throw exception before allocating response objects if request is invalid.