DecoratingHttp2ConnectionEncoder.consumeReceivedSettings must not throw if de…#9343
Merged
normanmaurer merged 1 commit into4.1from Jul 9, 2019
Merged
Conversation
Member
Author
|
No idea how I missed this while reviewing the original PR :( |
… if delegate is instance of Http2SettingsReceivedConsumer Motivation: b3dba31 introduced the concept of Http2SettingsReceivedConsumer but did not correctly inplement DecoratingHttp2ConnectionEncoder.consumeRemoteSettings(...). Modifications: - Add missing `else` around the throws - Add unit tests Result: Correctly implement DecoratingHttp2ConnectionEncoder.consumeRemoteSettings(...)
9c2a800 to
81c0456
Compare
Contributor
|
LGTM |
franz1981
approved these changes
Jul 9, 2019
Member
Author
|
Let me just merge this one as its an easy one. |
normanmaurer
added a commit
that referenced
this pull request
Jul 9, 2019
… if delegate is instance of Http2SettingsReceivedConsumer (#9343) Motivation: b3dba31 introduced the concept of Http2SettingsReceivedConsumer but did not correctly inplement DecoratingHttp2ConnectionEncoder.consumeRemoteSettings(...). Modifications: - Add missing `else` around the throws - Add unit tests Result: Correctly implement DecoratingHttp2ConnectionEncoder.consumeRemoteSettings(...)
| if (delegate instanceof Http2SettingsReceivedConsumer) { | ||
| ((Http2SettingsReceivedConsumer) delegate).consumeReceivedSettings(settings); | ||
| } else { | ||
| throw new IllegalStateException("delegate " + delegate + " is not an instance of " + |
Member
There was a problem hiding this comment.
this should be class cast exception, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…legate is instance of Http2SettingsReceivedConsumer
Motivation:
b3dba31 introduced the concept of Http2SettingsReceivedConsumer but did not correctly inplement DecoratingHttp2ConnectionEncoder.consumeReceivedSettings(...).
Modifications:
elsearound the throwsResult:
Correctly implement DecoratingHttp2ConnectionEncoder.consumeReceivedSettings(...)