HTTP2: Always apply the graceful shutdown timeout if configured#9340
Merged
normanmaurer merged 2 commits into4.1from Jul 9, 2019
Merged
HTTP2: Always apply the graceful shutdown timeout if configured#9340normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
Motivation: Http2ConnectionHandler (and sub-classes) allow to configure a graceful shutdown timeout but only apply it if there is at least one active stream. We should always apply the timeout. Modifications: - Always apply the timeout if one is configured - Add unit test Result: Always respect gracefulShutdownTimeoutMillis
ejona86
approved these changes
Jul 8, 2019
…use of a connectionError
960bd6b to
717b8bd
Compare
Member
Author
|
@ejona86 PTAL again as I noticed there is also another place where we should apply a timeout. |
ejona86
approved these changes
Jul 9, 2019
Member
|
These two new cases would probably benefit from using a separate timeout, since they should be much shorter periods of time whereas the normal graceful timeout could be an hour without being that big of a deal. But this is good for now. |
Member
Author
|
@ejona86 i can add another timeout just wanted to keep it simple for now... let me know |
Member
Author
|
@ejona86 let me just merge this for now and we can do another followup if needed. |
normanmaurer
added a commit
that referenced
this pull request
Jul 9, 2019
Motivation: Http2ConnectionHandler (and sub-classes) allow to configure a graceful shutdown timeout but only apply it if there is at least one active stream. We should always apply the timeout. This is also true when we try to send a GO_AWAY and close the connection because of an connection error. Modifications: - Always apply the timeout if one is configured - Add unit test Result: Always respect gracefulShutdownTimeoutMillis
Member
|
I was fine leaving it as-is at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Http2ConnectionHandler (and sub-classes) allow to configure a graceful shutdown timeout but only apply it if there is at least one active stream. We should always apply the timeout.
Modifications:
Result:
Always respect gracefulShutdownTimeoutMillis