Fix possible unsafe sharing of internal NIO buffer in CompositeByteBuf#9169
Merged
normanmaurer merged 1 commit intonetty:4.1from May 22, 2019
Merged
Fix possible unsafe sharing of internal NIO buffer in CompositeByteBuf#9169normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
Motivation A small thread-safety bug was introduced during the internal optimizations of ComponentByteBuf made a while back in netty#8437. When there is a single component which was added as a slice, internalNioBuffer(int,int) will currently return the unwrapped slice's un-duplicated internal NIO buffer. This is not safe since it could be modified concurrently with other usage of that parent buffer. Modifications Delegate internalNioBuffer to nioBuffer in this case, which returns a duplicate. This matches what's done in derived buffers in general (for the same reason). Add unit test. Result Fixed possible thread-safety bug
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
May 22, 2019
Member
|
@njhill good catch... Thanks! |
normanmaurer
pushed a commit
that referenced
this pull request
May 22, 2019
#9169) Motivation A small thread-safety bug was introduced during the internal optimizations of ComponentByteBuf made a while back in #8437. When there is a single component which was added as a slice, internalNioBuffer(int,int) will currently return the unwrapped slice's un-duplicated internal NIO buffer. This is not safe since it could be modified concurrently with other usage of that parent buffer. Modifications Delegate internalNioBuffer to nioBuffer in this case, which returns a duplicate. This matches what's done in derived buffers in general (for the same reason). Add unit test. Result Fixed possible thread-safety bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A small thread-safety bug was introduced during the internal optimizations of
ComponentByteBufmade a while back in #8437. When there is a single component which was added as a slice,internalNioBuffer(int,int)will currently return the unwrapped slice's un-duplicated internal NIO buffer. This is not safe since it could be modified concurrently with other usage of that parent buffer.Modifications
Delegate
internalNioBuffertonioBufferin this case, which returns a duplicate. This matches what's done in derived buffers in general (for the same reason). Add unit test.Result
Fixed possible thread-safety bug