ReferenceCountedOpenSslEngines SSLSession must provide local certific…#8918
Merged
normanmaurer merged 2 commits into4.1from Mar 8, 2019
Merged
ReferenceCountedOpenSslEngines SSLSession must provide local certific…#8918normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
normanmaurer
commented
Mar 5, 2019
Member
Author
There was a problem hiding this comment.
@normanmaurer Can you be more specific about what behavior you see in Conscrypt and what you think it should be doing?
Member
Author
There was a problem hiding this comment.
Basically what this PR fixes.
session.getLocalCertificates() and getLocalPrincipal() should not return null in the Trustmanager serverside. Check the included unit test
There was a problem hiding this comment.
Oh, on the server. Sure, makes sense. Weird that we don't do that, I've filed google/conscrypt#634 to track fixing it.
ea0af7b to
439c046
Compare
…ates during certificate verification Motivation: The SSLSession that is returned by SSLEngine.getHandshakeSession() must be able to provide the local certificates when the TrustManager is invoked on the server-side. Modifications: - Correctly return the local certificates - Add unit test Result: Be able to obtain local certificates from handshake SSLSession during verification on the server side.
439c046 to
acd7398
Compare
ejona86
approved these changes
Mar 7, 2019
normanmaurer
added a commit
that referenced
this pull request
Mar 8, 2019
#8918) Motivation: The SSLSession that is returned by SSLEngine.getHandshakeSession() must be able to provide the local certificates when the TrustManager is invoked on the server-side. Modifications: - Correctly return the local certificates - Add unit test Result: Be able to obtain local certificates from handshake SSLSession during verification on the server side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ates during certificate verification
Motivation:
The SSLSession that is returned by SSLEngine.getHandshakeSession() must be able to provide the local certificates when the TrustManager is invoked on the server-side.
Modifications:
Result:
Be able to obtain local certificates from handshake SSLSession during verification on the server side.