Use maven plugin to prevent API/ABI breakage as part of build process#8904
Merged
normanmaurer merged 2 commits into4.1from Mar 1, 2019
Merged
Use maven plugin to prevent API/ABI breakage as part of build process#8904normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
Motivation: Netty is very widely used which can lead to a lot of pain when we break API / ABI. We should make use japicmp-maven-plugin during the build to verify we do not introduce breakage by mistake. Modifications: - Add japicmp-maven-plugin to the build process - Fix a method signature change in HttpProxyHandler that was flagged as a possible problem. Result: Ensure no API/ABI breakage accour between releases.
normanmaurer
commented
Mar 1, 2019
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>netty-handler</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> |
Member
Author
There was a problem hiding this comment.
this was incorrect as it is not really an optional dependency.
normanmaurer
commented
Mar 1, 2019
|
|
||
| @Override | ||
| protected boolean handleResponse(ChannelHandlerContext ctx, Object response) throws HttpProxyConnectException { | ||
| protected boolean handleResponse(ChannelHandlerContext ctx, Object response) throws Exception { |
Member
Author
There was a problem hiding this comment.
This was flagged as a breakage so I fixed it. That said I think this is a false positive as HttpProxyHandler is final so there should be no problem here in reality.
ejona86
approved these changes
Mar 1, 2019
Member
ejona86
left a comment
There was a problem hiding this comment.
It's a bit worrying that it doesn't understand final classes too well, but it can still be helpful.
Member
Author
|
@ejona86 I will open an issue for it and hopefully they can fix it |
normanmaurer
added a commit
that referenced
this pull request
Mar 1, 2019
…#8904) Motivation: Netty is very widely used which can lead to a lot of pain when we break API / ABI. We should make use japicmp-maven-plugin during the build to verify we do not introduce breakage by mistake. Modifications: - Add japicmp-maven-plugin to the build process - Fix a method signature change in HttpProxyHandler that was flagged as a possible problem. Result: Ensure no API/ABI breakage accour between releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Netty is very widely used which can lead to a lot of pain when we break API / ABI. We should make use japicmp-maven-plugin during the build to verify we do not introduce breakage by mistake.
Modifications:
Result:
Ensure no API/ABI breakage accour between releases.