Skip to content

Adjust tests to be able to build / test when using IBM J9 / OpenJ9#8900

Merged
normanmaurer merged 1 commit into4.1from
j9
Mar 1, 2019
Merged

Adjust tests to be able to build / test when using IBM J9 / OpenJ9#8900
normanmaurer merged 1 commit into4.1from
j9

Conversation

@normanmaurer
Copy link
Copy Markdown
Member

Motivation:

We should run a CI job using J9 to ensure netty also works when using different JVMs.

Modifications:

  • Adjust PooledByteBufAllocatorTest to be able to complete faster when using a JVM which takes longer when joining Threads (this seems to be the case with J9).
  • Skip UDT tests on J9 as UDT is not supported there.

Result:

Be able to run CI against J9.

Motivation:

We should run a CI job using J9 to ensure netty also works when using different JVMs.

Modifications:

- Adjust PooledByteBufAllocatorTest to be able to complete faster when using a JVM which takes longer when joining Threads (this seems to be the case with J9).
- Skip UDT tests on J9 as UDT is not supported there.

Result:

Be able to run CI against J9.
@normanmaurer normanmaurer merged commit 90ea3ec into 4.1 Mar 1, 2019
@normanmaurer normanmaurer deleted the j9 branch March 1, 2019 05:48
normanmaurer added a commit that referenced this pull request Mar 1, 2019
…8900)

Motivation:

We should run a CI job using J9 to ensure netty also works when using different JVMs.

Modifications:

- Adjust PooledByteBufAllocatorTest to be able to complete faster when using a JVM which takes longer when joining Threads (this seems to be the case with J9).

Result:

Be able to run CI against J9.
Copy link
Copy Markdown
Member

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t.markAsFinished();
}

for (AllocationThread t: threads) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants