Adjust tests to be able to build / test when using IBM J9 / OpenJ9#8900
Merged
normanmaurer merged 1 commit into4.1from Mar 1, 2019
Merged
Adjust tests to be able to build / test when using IBM J9 / OpenJ9#8900normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
Motivation: We should run a CI job using J9 to ensure netty also works when using different JVMs. Modifications: - Adjust PooledByteBufAllocatorTest to be able to complete faster when using a JVM which takes longer when joining Threads (this seems to be the case with J9). - Skip UDT tests on J9 as UDT is not supported there. Result: Be able to run CI against J9.
ejona86
approved these changes
Feb 28, 2019
normanmaurer
added a commit
that referenced
this pull request
Mar 1, 2019
…8900) Motivation: We should run a CI job using J9 to ensure netty also works when using different JVMs. Modifications: - Adjust PooledByteBufAllocatorTest to be able to complete faster when using a JVM which takes longer when joining Threads (this seems to be the case with J9). Result: Be able to run CI against J9.
| t.markAsFinished(); | ||
| } | ||
|
|
||
| for (AllocationThread t: threads) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We should run a CI job using J9 to ensure netty also works when using different JVMs.
Modifications:
Result:
Be able to run CI against J9.