Support delegating task when using ReferenceCountedOpenSslEngine.#8859
Support delegating task when using ReferenceCountedOpenSslEngine.#8859normanmaurer merged 1 commit into4.1from
Conversation
|
This depends on netty/netty-tcnative#430 |
ecbb0eb to
f2c1721
Compare
ejona86
left a comment
There was a problem hiding this comment.
Looks good, although I don't think I'd be able to notice any bugs.
| SSLContext.enableOcsp(ctx, isClient()); | ||
| } | ||
|
|
||
| // TODO: Make the configurable. |
There was a problem hiding this comment.
Is it just that we want to avoid unstable code, or is there a reason to believe it would have a performance cost?
There was a problem hiding this comment.
@ejona86 its more to allow to test it a bit more before make it default. I also still need to do some performance tests but I suspect the impact should be almost zero.
There was a problem hiding this comment.
Then system property sounds good. When we are comfortable we change the default. When it is "proven" we remove the option.
There was a problem hiding this comment.
Alright I introduced the system property "io.netty.handler.ssl.openssl.useTasks"
handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
Outdated
Show resolved
Hide resolved
6fbc574 to
6e3d4ce
Compare
|
@netty-bot test this please |
1 similar comment
|
@netty-bot test this please |
|
Let me merge this once we release netty-tcnative 2.0.21.Final |
|
@netty-bot test this please |
71df563 to
f1c2fe0
Compare
Motivation: SSLEngine API has a notion of tasks that may be expensive and offload these to another thread. We did not support this when using our native implementation but can now for various operations during the handshake. Modifications: - Support offloading tasks during the handshake when using our native SSLEngine implementation - Correctly handle the case when NEED_TASK is returned and nothing was consumed / produced yet Result: Be able to offload long running tasks from the EventLoop when using SslHandler with our native SSLEngine.
f1c2fe0 to
20454a1
Compare
|
@netty-bot test this please |
) Motivation: SSLEngine API has a notion of tasks that may be expensive and offload these to another thread. We did not support this when using our native implementation but can now for various operations during the handshake. Modifications: - Support offloading tasks during the handshake when using our native SSLEngine implementation - Correctly handle the case when NEED_TASK is returned and nothing was consumed / produced yet Result: Be able to offload long running tasks from the EventLoop when using SslHandler with our native SSLEngine.
Motivation:
SSLEngine API has a notion of tasks that may be expensive and offload these to another thread. We did not support this when using our native implementation but can now for various operations during the handshake.
Modifications:
Result:
Be able to offload long running tasks from the EventLoop when using SslHandler with our native SSLEngine.