Can one of the admins verify this patch?

@netty-bot test this please

I added tests (to existing) compression/encoding tests - but I was not able to test decompression/decoding. I will try tomorrow.

@netty-bot test this please

@normanmaurer so, should I add test for decompression/decoding ? because I see that you approved this already.

@KowalczykBartek if you can sure... that said if you are too busy its fine as well and we can do a followup.

No, I will do it today, please wait with merging.

update: I was not able to finish that test - cannot pass trailing headers in decompression, i will continue that tomorrow.

@KowalczykBartek let me know once done as I would like to include this in the next release if possible

@normanmaurer I created test (that was challenging :D ). The only problem with that test is ... It do not pass, because my trailer is missing - after some debugging I noticed that it(trailer) is correctly parsed but at the end is ignored :(
HttpObjectDecoder in line 675 is decoding trailer, then it is trying to parse headers (?), if headerParsers return null, it ignores my trailer.

line = headerParser.parse(buffer);
if (line == null) {
    return null;
}

I modified slightly this code,

line = headerParser.parse(buffer);
if (line == null) {
    if(!trailer.trailingHeaders().isEmpty())
    {
        this.trailer = null;
        return trailer;
    }
    return null;
}

and my test pass - but for sure this change breaks other stuff :D I will try to understand HttpObjectDecoder, but maybe you see mistake that I done in my test (or there is a bug in parsing logic)?

Thanks in advance :)

yeah ! I figured out what was wrong - and pushed the change !

Question:
Can I say that it is a bug when HttpObjectDecoder cannot parse that:

assertTrue(channel.writeInbound(Unpooled.copiedBuffer("My-Trailer: 42", CharsetUtil.US_ASCII)));
assertTrue(channel.writeInbound(Unpooled.copiedBuffer("\r\n", CharsetUtil.US_ASCII)));
assertTrue(channel.writeInbound(Unpooled.copiedBuffer("\r\n\r\n", CharsetUtil.US_ASCII)));

but can parse that:

assertTrue(channel.writeInbound(Unpooled.copiedBuffer("My-Trailer: 42\r\n\r\n\r\n", CharsetUtil.US_ASCII)));

?

I created an issue : #8736

@netty-bot test this please

@KowalczykBartek please fix the checkstyle errors:

13:35:18 /code/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java:104:52: Unnecessary parentheses around expression.
13:35:18 /code/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java:106: Line is longer than 120 characters (found 139).
13:35:18 Audit done.
13:35:18

Also please ensure you release all messages that implement ReferenceCounted

Fixed checkstyle errors (now no errors after mvn clean package) - btw sorry I forget about code-style :D

Also please ensure you release all messages that implement ReferenceCounted

Fixed, from what I understand only DefaultHttpContent has disposable content.

@netty-bot Test this please

@KowalczykBartek thanks a lot!