Fixed|SimpleChannelPool.close() should only return after complete.#7927
Merged
normanmaurer merged 1 commit into4.1from May 21, 2018
Merged
Fixed|SimpleChannelPool.close() should only return after complete.#7927normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
Motivation: We need to ensure we only return from close() after all work is done as otherwise we may close the EventExecutor before we dispatched everything. Modifications: Correctly wait on operations to complete before return. Result: Fixes #7901.
Member
Author
|
@trustin ping |
trustin
approved these changes
May 21, 2018
13 tasks
dagnir
added a commit
to dagnir/aws-sdk-java-v2
that referenced
this pull request
Mar 12, 2019
Backport changes from netty/netty#7927, which fixes the close method so that the call to the delegateChannelPool#close is done on a separate thread that isn't the executor.
dagnir
added a commit
to aws/aws-sdk-java-v2
that referenced
this pull request
Mar 13, 2019
Backport changes from netty/netty#7927, which fixes the close method so that the call to the delegateChannelPool#close is done on a separate thread that isn't the executor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure we only return from close() after all work is done as otherwise we may close the EventExecutor before we dispatched everything.
Modifications:
Correctly wait on operations to complete before return.
Result:
Fixes #7901.