Skip to content

implements read/writeUTF8#785

Closed
matlach wants to merge 1 commit intonetty:masterfrom
matlach:master
Closed

implements read/writeUTF8#785
matlach wants to merge 1 commit intonetty:masterfrom
matlach:master

Conversation

@matlach
Copy link
Copy Markdown

@matlach matlach commented Dec 1, 2012

based on jdk 7 DataInput/OutputStream

@trustin
Copy link
Copy Markdown
Member

trustin commented Dec 1, 2012

I don't think we can accept this request due to licensing issues. Isn't it GPL or proprietary?

@normanmaurer
Copy link
Copy Markdown
Member

Exactly... No way to accept it

@matlach
Copy link
Copy Markdown
Author

matlach commented Dec 1, 2012

really ? we cannot use jdk source ?! that code hasn't changed since jdk 1.0

@normanmaurer
Copy link
Copy Markdown
Member

Yes... Its license is not compatible with ASL2

Sent from my iPhone. Excuse any typos....

Am 01.12.2012 um 20:25 schrieb matlach notifications@github.com:

really ? we cannot use jdk source ?!


Reply to this email directly or view it on GitHub.

@dantran
Copy link
Copy Markdown
Contributor

dantran commented Dec 2, 2012

OpenJDK source is GPLv2 with 'Classpath Exception'. The classpath exception allows you to ship the JRE/JDK without the need to expose your own code. However, it does not give you the right to change its license :(

so Matlach, you are contaminated :-). We need a clean room implementation

@normanmaurer
Copy link
Copy Markdown
Member

Can't be included because of license issues

@matlach
Copy link
Copy Markdown
Author

matlach commented Dec 3, 2012

can we still open a feature request ?
#687

maybe i'll have (or someone) the time to figure eventually something else :)

@trustin
Copy link
Copy Markdown
Member

trustin commented Dec 3, 2012

Sure! It's still on our road map.

@lukehutch
Copy link
Copy Markdown
Contributor

See the links I added to #909 .

chrisvest pushed a commit to chrisvest/netty that referenced this pull request Apr 3, 2025
Motivation:

We only link against the quiche package so we only need to build it with
cargo

Modifications:

Only build quiche package

Result:

Speedup build and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants