Conversation
danbev
commented
Sep 9, 2012
- Refactoring and adding suggestions from Norman and Vibul.
- Refactoring and adding suggestions from Norman and Vibul.
|
@danbev you handled the future the right way. I think its wrong to throw an exception in the WebSocketHandshaker, I will look into this as a separate issue :) Would you mind to also create a pull request for 3.x ? |
|
Sure no problem, I'll create a pull request for 3.x. Den 9 sep 2012 11.28, "Norman Maurer" notifications@github.com skrev: @danbev https://github.com/danbev you handled the future the right way. I — |
|
Thanks a lot! Sent from my iPhone. Excuse any typos.... Am 09.09.2012 um 12:09 schrieb Daniel Bevenius notifications@github.com:
|
|
Thanks @danbev :-) Let me know if you need a hand working on the other enhancements. Can I also ask for a change of name form WebSocketServerHandshakeHandler to WebSocketServerProtocolHandshakeHandler? The reason is so that it is clear that the class is to be used with WebSocketServerProtocolHandler. Another alternative is to just make it an inner class of WebSocketServerProtocolHandler and be done with it??? I'm just worried that users might get confused which handshaker to use. If you are busy, let me know and I can do it. Thanks again for your pull request. |
…shakeHandler and also make it public. See #587
…peline before adding it. See #587
…ebSocketHandshakeException. See #587
|
@danbev I also fixed bug which could lead to get the channel closed before the BAD_REQUEST was written to the client |
|
@normanmaurer Thanks for your help and I'll make sure to look at the fixes you made so that I don't repeat them. |
|
Yep I renamed the class Sent from my iPhone. Excuse any typos.... Am 10.09.2012 um 09:08 schrieb Daniel Bevenius notifications@github.com:
|
netty#587) …eference Motivation: We missed to delete the local reference in some cases due early returns. Modifications: Move the delete calls close to the creation calls and so ensure we not miss to delete local references Result: More correct code