Hi @danbev.

Thanks for the pull request and I think it is a really good idea.

I originally put together the websocketx code for V3. I would like to quickly discuss naming.

I think it may be better if WebSocketHandshakeHandler and WebSocketProtocolHandler gives a netty user an indication if it is meant for client or server usage (just like the WebSocketClientHandshakeHandler and WebSocketServerHandshakeHandler.

How about WebSocketServerProtocolHandler and WebSocketServerProtocolHandshakeHandler? In this way, from the class name, it is clear that it is for web socket server usage and for protocol handling.

A few other questions/issues:

• getWebSocketLocation() may need to know if SSL is being used or not. If SSL is being used, then the preifx should be "wss://"
• What if a netty user wants to do something when the web socket is closed? Should there be an optional event that gets raised (or similar) when a socket is closed?
• Working on another project with netty, socko, one user needed to know when handshake has completed because he wanted to start sending messages from server to client ASAP. Outside the protocol handler, one would just need to put the logic after handshaking. This is not possible from the proposed protocol handler. How about a similar optional event (or similar) when handshake has completed?

Thanks
Vibul