3 - fix for issue #569#572
Merged
normanmaurer merged 2 commits intonetty:3from Aug 28, 2012
fredericBregier:3
Merged
Conversation
When moving to take into account arrayOffset, it should have been taken into account also in setReadPosition and other places. Fix it now...
When moving to take into account arrayOffset, it should have been taken into account also in setReadPosition and other places. Fix it now... Also fix mismatch algorithm between SeekAheadOptimize and not SeekAheadOptimize (standard) versions.
normanmaurer
added a commit
that referenced
this pull request
Aug 28, 2012
Member
|
@fredericBregier ok pulled in an fixed the issues ;) Thanks! |
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Apr 2, 2025
…etty#572) Motivation: When caching fails during workflow execution we should still continue the build as its just an optimization. Also we should use the new fork for docker layer caching Modifications: - Update action that does the docker layer caching to the new fork - Ignore errors during caching Result: More stable builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix all issues from #569
When moving to take into account arrayOffset, it should have been taken into account also in setReadPosition and other places. Fix it now...
Also fix mismatch algorithm between SeekAheadOptimize and not SeekAheadOptimize (standard) versions.
NB: I didn't have a chance to check the "typo" check (not in condition where I have all I need under my hands), so you might check that it compiles with mvn correctly first. Sorry for that inconvenient...