Added boolean methods to ChannelBuffer in 3.2#48
Closed
CruzBishop wants to merge 1 commit intonetty:3.2from
CruzBishop:3.2-channelbuffer-boolean
Closed
Added boolean methods to ChannelBuffer in 3.2#48CruzBishop wants to merge 1 commit intonetty:3.2from CruzBishop:3.2-channelbuffer-boolean
CruzBishop wants to merge 1 commit intonetty:3.2from
CruzBishop:3.2-channelbuffer-boolean
Conversation
Member
|
this breaks the api so it will not go in 3.2 , sorry. |
Contributor
Author
|
That's fine, it's already in 4.0 alpha 1, so I did this up quickly to see if it would fit in 3.2 |
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Apr 2, 2025
…etty#48) Motivation: `quiche::connect` function takes an option `server_name` argument for peer's certificate verification. Previously was always set to NULL. Modifications: * Defines `QuicChannelConfig` to be used instead of default with additional `QUIC_PEER_CERT_SERVER_NAME` option * When creating Quiche connection, uses `server_name` set into the config (if any) Result: Full coverage for `quiche::connect` arguments, fixes netty#16 Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #46
"Adds getBoolean(index), readBoolean(), writeBoolean(value), and setBoolean(index, value) to ChannelBuffer
Added the corresponding boundary tests
Fixed a few spacing issues, nothing big"