Skip to content

ignore HttpOnly as a cookie name instead of throwing exception#47

Merged
normanmaurer merged 2 commits intonetty:masterfrom
jpinner:ignore_httponly_cookies
Nov 9, 2011
Merged

ignore HttpOnly as a cookie name instead of throwing exception#47
normanmaurer merged 2 commits intonetty:masterfrom
jpinner:ignore_httponly_cookies

Conversation

@jpinner
Copy link
Copy Markdown

@jpinner jpinner commented Nov 7, 2011

No description provided.

@normanmaurer
Copy link
Copy Markdown
Member

I think it would make more sense to have this configurable via an constructor argument. So what about modify and update the pull request?

normanmaurer added a commit that referenced this pull request Nov 9, 2011
ignore HttpOnly as a cookie name instead of throwing exception
@normanmaurer normanmaurer merged commit 7820731 into netty:master Nov 9, 2011
@jpinner
Copy link
Copy Markdown
Author

jpinner commented Nov 9, 2011

also merge into 3.2?

@normanmaurer
Copy link
Copy Markdown
Member

Trustin wanted to have a look at if its possible to merge it into 3.2 too. If you can write a patch that can be easily merged to 3.2 then even better ;) Thanks

@jpinner
Copy link
Copy Markdown
Author

jpinner commented Nov 9, 2011

pull request #50

@normanmaurer
Copy link
Copy Markdown
Member

Done.. Thanks again

chrisvest pushed a commit to chrisvest/netty that referenced this pull request Apr 2, 2025
Motivation:

How the bootstrapping for client side worked was kind of hacky and also brought up some limitations, like how to set different options / attributes etc. This was also true to some extend for the serverside.

Modifications:

- Move randomGenerator() to Quic class
- Rename QuicBuilder to QuicCodecBuilder, rename QuicClientBuilder to QuicClientCodecBuilder, rename QuicServerBuilder to QuicServerCodecBuilder
- Introduce QuicChannelBootstrap that can be used to create QuicChannels that can be used for client side
- Add ability to set handler / streamHandler, option / streamOption, attr / streamAttr to QuicServerBuilder and QuicChannelBootstrap
- Move some logic related to how handlers are added to QuicChannel

Result:

Cleaner and more consistent API and also fixes netty/netty-incubator-codec-quic#23
chrisvest pushed a commit to chrisvest/netty that referenced this pull request Apr 18, 2025
Motivation:

We should use latest quic codec version

Modifications:

Update to 0.0.2.Final

Result:

Use latest quic codec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants