Closed
Conversation
Motivation: The logger was always performing a hex dump of the ByteBufs regarless whether or not the log would take place. Modifications: Fixed the logger to avoid serializing the ByteBufs and calling the varargs method if logging is not enabled. Result: The loggers should run MUCH faster when disabled.
Member
Author
|
@Scottmitch and @louiscryan can you take a look |
There was a problem hiding this comment.
don't have to create a slice, can use
ByteBufUtil.hexDump(buf, buffer.readerIndex(), length)
|
LGTM |
Member
Author
|
This is simple so I'm just cherrypicking ... in master and 4.1. |
Member
|
@nmittler - Yes this looks good :) |
Gordiychuk
added a commit
to Gordiychuk/netty
that referenced
this pull request
Jul 26, 2017
Currentry logger create hex dump even if log write will not apply. It's unecessary GC overhead. Restore optiomization from netty#3492 Close netty#7025
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this pull request
Sep 10, 2017
Motivation: Currentry logger create hex dump even if log write will not apply. It's unecessary GC overhead. Modifications: Restore optimization from netty#3492 Result: Fixes netty#7025
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this pull request
Feb 28, 2018
Motivation: Currentry logger create hex dump even if log write will not apply. It's unecessary GC overhead. Modifications: Restore optimization from netty#3492 Result: Fixes netty#7025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The logger was always performing a hex dump of the ByteBufs regarless whether or not the log would take place.
Modifications:
Fixed the logger to avoid serializing the ByteBufs and calling the varargs method if logging is not enabled.
Result:
The loggers should run MUCH faster when disabled.