Make bulk byte moving in ByteBuf faster#16780
Merged
Merged
Conversation
Member
Author
|
This should fix the consistently failing tests we have in the 5.0 branch. |
Motivation: ByteBuf.getBytes is important for the performance of many bulk byte moving operations. When the leak detector is enabled, calls like `nioBufferCount`, `nioBuffers`, and `internalNioBuffer` can produce expensive recording calls. Modification: - Unwrap the destination buffer if it is wrapped. - Use `absolutePut` operations on the internal NIO buffer to avoid allocating `ByteBuffer` instances. Result: Bulk byte move operations are faster. So much so that the `DataCompressionHttp2Test.encodingTooBigMessage` test no longer fails on a timeout.
f0fe918 to
217bf9b
Compare
franz1981
approved these changes
May 9, 2026
franz1981
left a comment
Contributor
There was a problem hiding this comment.
LGTM! How did you find it? Profiling the CI on failed tests?
Member
Author
|
Noticed the unsafe buffer build was not failing. The difference is it runs without leak detection enabled. Enabling that locally the test still passed but took 2 seconds on 5.0, and half a second on 4.2. Profiled the tests and the difference became pretty clear. |
Contributor
|
Auto-port PR for 4.2: #16781 |
normanmaurer
pushed a commit
that referenced
this pull request
May 10, 2026
Auto-port of #16780 to 4.2 Cherry-picked commit: 37db5d7 --- Motivation: ByteBuf.getBytes is important for the performance of many bulk byte moving operations. When the leak detector is enabled, calls like `nioBufferCount`, `nioBuffers`, and `internalNioBuffer` can produce expensive recording calls. Modification: - Unwrap the destination buffer if it is wrapped. - Use `absolutePut` operations on the internal NIO buffer to avoid allocating `ByteBuffer` instances. Result: Bulk byte move operations are faster. So much so that the `DataCompressionHttp2Test.encodingTooBigMessage` test no longer fails on a timeout. Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ByteBuf.getBytes is important for the performance of many bulk byte moving operations.
When the leak detector is enabled, calls like
nioBufferCount,nioBuffers, andinternalNioBuffercan produce expensive recording calls.Modification:
absolutePutoperations on the internal NIO buffer to avoid allocatingByteBufferinstances.Result:
Bulk byte move operations are faster.
So much so that the
DataCompressionHttp2Test.encodingTooBigMessagetest no longer fails on a timeout.