HTTP2: Ensure HTTP2 preface is always send as first message (also on the server)#16667
Merged
Conversation
…the server) Motivation: caf6f41 introduced a fix that ensured we always send the preface as the first message on the client but didn't also fix it for the server side. Modifications: - Ensure we always send the preface before we give the user a chance to write another frame. Result: More complete fix
Member
Author
|
@chrisvest PTAL |
chrisvest
approved these changes
Apr 17, 2026
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
Member
|
5.0 port #16674 |
Member
|
4.1 port #16675 |
normanmaurer
added a commit
that referenced
this pull request
Apr 21, 2026
#16674) …the server) (#16667) Motivation: caf6f41 introduced a fix that ensured we always send the preface as the first message on the client but didn't also fix it for the server side. Modifications: - Ensure we always send the preface before we give the user a chance to write another frame. Result: More complete fix Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Apr 21, 2026
#16675) …the server) (#16667) Motivation: caf6f41 introduced a fix that ensured we always send the preface as the first message on the client but didn't also fix it for the server side. Modifications: - Ensure we always send the preface before we give the user a chance to write another frame. Result: More complete fix (cherry picked from commit 29a19f2) Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
caf6f41 introduced a fix that ensured we always send the preface as the first message on the client but didn't also fix it for the server side.
Modifications:
Result:
More complete fix