ByteBufAllocatorAllocPatternBenchmark: Ensure each index appears exactly once in releaseIndexes#16604
Merged
Merged
Conversation
franz1981
approved these changes
Apr 5, 2026
franz1981
left a comment
Contributor
There was a problem hiding this comment.
Nice catch! Well done!
Contributor
|
Auto-port PR for 5.0: #16678 |
Contributor
|
Could not create auto-port PR. |
Member
|
No backport needed. This benchmark does not exist in 4.1. |
chrisvest
pushed a commit
that referenced
this pull request
Apr 22, 2026
…ex appears exactly once in releaseIndexes (#16678) Auto-port of #16604 to 5.0 Cherry-picked commit: 61d3c4a --- Motivation: In `ByteBufAllocatorAllocPatternBenchmark`, the original random sampling allowed the same index to be selected multiple times, making live buffer count unpredictable and causing `MAX_LIVE_BUFFERS` to lose its intended meaning. Modification: Use [Fisher-Yates](https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle) shuffle for releaseIndexes. Result: Live buffer count is stable at `MAX_LIVE_BUFFERS`, each index appears exactly once in releaseIndexes. Co-authored-by: old driver <29225782+laosijikaichele@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In
ByteBufAllocatorAllocPatternBenchmark, the original random sampling allowed the same index to be selected multiple times, making live buffer count unpredictable and causingMAX_LIVE_BUFFERSto lose its intended meaning.Modification:
Use Fisher-Yates shuffle for releaseIndexes.
Result:
Live buffer count is stable at
MAX_LIVE_BUFFERS, each index appears exactly once in releaseIndexes.