Increase timeouts for QuicChannelConnectTest#16564
Merged
Merged
Conversation
Motivation: Locally, a few of these tests take over 3 seconds to run, but their timeout is only 5 seconds. This causes them to often time out in CI. Modification: Increase the timeouts to 10 seconds. Result: More stable build.
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
Motivation: Locally, a few of these tests take over 3 seconds to run, but their timeout is only 5 seconds. This causes them to often time out in CI. Modification: Increase the timeouts to 10 seconds. Result: More stable build. It's the same in 4.2, so this needs to be cherry-picked. (cherry picked from commit 5a1b511)
Contributor
|
Auto-port PR for 4.2: #16578 |
chrisvest
added a commit
that referenced
this pull request
Mar 31, 2026
Auto-port of #16564 to 4.2 Cherry-picked commit: 5a1b511 --- Motivation: Locally, a few of these tests take over 3 seconds to run, but their timeout is only 5 seconds. This causes them to often time out in CI. Modification: Increase the timeouts to 10 seconds. Result: More stable build. It's the same in 4.2, so this needs to be cherry-picked. Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Locally, a few of these tests take over 3 seconds to run, but their timeout is only 5 seconds. This causes them to often time out in CI.
Modification:
Increase the timeouts to 10 seconds.
Result:
More stable build.
It's the same in 4.2, so this needs to be cherry-picked.