Fix Socket reading of abstract unix domain addresses#16010
Merged
Conversation
Motivation: How we calculated the length of the unix domain socket address was not correct. Motification: Follow the manpage in how the length is calculated Result: Always return the correct name for abstract unix domain sockets
chrisvest
requested changes
Dec 10, 2025
Abstract domain socket paths are always at least sized sizeof(sa_family_t) or greater.
chrisvest
approved these changes
Dec 11, 2025
normanmaurer
added a commit
that referenced
this pull request
Dec 11, 2025
Motivation: How we calculated the length of the unix domain socket address was not correct. Motification: Follow the manpage in how the length is calculated Result: Always return the correct name for abstract unix domain sockets --------- Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Dec 11, 2025
Motivation: How we calculated the length of the unix domain socket address was not correct. Motification: Follow the manpage in how the length is calculated Result: Always return the correct name for abstract unix domain sockets --------- Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Dec 11, 2025
Motivation: How we calculated the length of the unix domain socket address was not correct. Motification: Follow the manpage in how the length is calculated Result: Always return the correct name for abstract unix domain sockets Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Dec 11, 2025
Motivation: How we calculated the length of the unix domain socket address was not correct. Motification: Follow the manpage in how the length is calculated Result: Always return the correct name for abstract unix domain sockets --------- Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
How we calculated the length of the unix domain socket address was not correct.
Motification:
Follow the manpage in how the length is calculated
Result:
Always return the correct name for abstract unix domain sockets