Testsuite: Make testing with wrapped / direct buffers more random#15281
Merged
Testsuite: Make testing with wrapped / direct buffers more random#15281
Conversation
Motivation: In our testsuite we often just wrapped a byte[] and passed it to the write method. While this works it also might end up not testing often with direct buffers. We should make this a bit more random and so cover direct and heap buffers. The idea popped up when reviewing #15231 Modifications: - Add new static helper method that will either return a wrapped buffer or a direct buffers in a random fashion - Use this method to allocate buffers Result: More random testing of heap / direct buffers
6cdfc5b to
0f1cac4
Compare
chrisvest
approved these changes
May 28, 2025
normanmaurer
added a commit
that referenced
this pull request
Jun 23, 2025
…5281) Motivation: In our testsuite we often just wrapped a byte[] and passed it to the write method. While this works it also might end up not testing often with direct buffers. We should make this a bit more random and so cover direct and heap buffers. The idea popped up when reviewing #15231 Modifications: - Add new static helper method that will either return a wrapped buffer or a direct buffers in a random fashion - Use this method to allocate buffers Result: More random testing of heap / direct buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In our testsuite we often just wrapped a byte[] and passed it to the write method. While this works it also might end up not testing often with direct buffers. We should make this a bit more random and so cover direct and heap buffers. The idea popped up when reviewing #15231
Modifications:
Result:
More random testing of heap / direct buffers