Kqueue: Delay removal from registration map to fix noisy warnings#15279
Merged
normanmaurer merged 1 commit into4.2from May 29, 2025
Merged
Kqueue: Delay removal from registration map to fix noisy warnings#15279normanmaurer merged 1 commit into4.2from
normanmaurer merged 1 commit into4.2from
Conversation
Member
Author
|
This could also be observed when running the Kqueue tests. |
Member
Author
|
We also need a variant of this in 4.1 |
Member
Author
|
/cc @daschl |
Motivation: In Kqueue it sometimes happened that we did see a WARN that the registration for a given id could not be found. The reason for this was that it is possible that the registration was already be cancelled by the user and so not present anymore. In this case the logs are harmless but still confusing. We should better ensure we handle it better. Modifications: When the user cancels a registration just mark it as cancelled and remove it from the map one all events are processed. Result: Less confusing logging and more correct handling of cancelled registrations
e425ad6 to
7a48b37
Compare
chrisvest
approved these changes
May 28, 2025
Comment on lines
+280
to
+284
| for (;;) { | ||
| DefaultKqueueIoRegistration cancelledRegistration = cancelledRegistrations.poll(); | ||
| if (cancelledRegistration == null) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Can also be written like this
Suggested change
| for (;;) { | |
| DefaultKqueueIoRegistration cancelledRegistration = cancelledRegistrations.poll(); | |
| if (cancelledRegistration == null) { | |
| return; | |
| } | |
| DefaultKqueueIoRegistration cancelledRegistration; | |
| while ((cancelledRegistration = cancelledRegistrations.poll()) != null) { |
Member
Author
There was a problem hiding this comment.
I actually prefer the other style and it's also what we use in other places.
Member
Author
|
Will work on a port to 4.1 |
normanmaurer
added a commit
that referenced
this pull request
May 30, 2025
…5279) Motivation: In Kqueue it sometimes happened that we did see a WARN that the registration for a given id could not be found. The reason for this was that it is possible that the registration was already be cancelled by the user and so not present anymore. In this case the logs are harmless but still confusing. We should better ensure we handle it better. Modifications: When the user cancels a registration just mark it as cancelled and remove it from the map one all events are processed. Result: Less confusing logging and more correct handling of cancelled registrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In Kqueue it sometimes happened that we did see a WARN that the registration for a given id could not be found. The reason for this was that it is possible that the registration was already be cancelled by the user and so not present anymore. In this case the logs are harmless but still confusing. We should better ensure we handle it better.
Modifications:
When the user cancels a registration just mark it as cancelled and remove it from the map one all events are processed.
Result:
Less confusing logging and more correct handling of cancelled registrations