Always prefer direct buffers for pooled allocators if not explicit di…#15232
Merged
normanmaurer merged 1 commit into4.2from May 22, 2025
Merged
Always prefer direct buffers for pooled allocators if not explicit di…#15232normanmaurer merged 1 commit into4.2from
normanmaurer merged 1 commit into4.2from
Conversation
franz1981
reviewed
May 22, 2025
Contributor
franz1981
left a comment
There was a problem hiding this comment.
We could even wait till @chrisvest changes are merged and consider safe to always use direct ones only if the cleaner won't delay freeing up them e.g. Unsafe and FFM versions.
This will make a more elastic and effective ergonomics
Member
Author
|
@franz1981 maybe... I think this change might still be a good one even without what @chrisvest did. Especially when thinking about 4.1 |
chrisvest
approved these changes
May 22, 2025
…sabled Motivation: We should always prefer direct buffers if the ByteBufAllocator implementations are pooled as deallocating these buffers should be rare. Modifications: - Add new method to PlatformDependent that can be used to check if default direct buffer usage was explicit disabled - Use this method in our pooled ByteBufAllocator implementations to check if we should use direct buffers or not by default Result: Less memory copies and better performance when using the pooled allocators even if Unsafe can not be used.
7c28748 to
25ca875
Compare
Member
Author
|
@chrisvest I think we also want this for 4.1, agree ? |
Member
Sure |
normanmaurer
added a commit
that referenced
this pull request
May 22, 2025
#15232) …sabled Motivation: We should always prefer direct buffers if the ByteBufAllocator implementations are pooled as deallocating these buffers should be rare. Modifications: - Add new method to PlatformDependent that can be used to check if default direct buffer usage was explicit disabled - Use this method in our pooled ByteBufAllocator implementations to check if we should use direct buffers or not by default Result: Less memory copies and better performance when using the pooled allocators even if Unsafe can not be used.
normanmaurer
added a commit
that referenced
this pull request
May 23, 2025
#15245) …… (#15232) …sabled Motivation: We should always prefer direct buffers if the ByteBufAllocator implementations are pooled as deallocating these buffers should be rare. Modifications: - Add new method to PlatformDependent that can be used to check if default direct buffer usage was explicit disabled - Use this method in our pooled ByteBufAllocator implementations to check if we should use direct buffers or not by default Result: Less memory copies and better performance when using the pooled allocators even if Unsafe can not be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sabled
Motivation:
We should always prefer direct buffers if the ByteBufAllocator implementations are pooled as deallocating these buffers should be rare.
Modifications:
Result:
Less memory copies and better performance when using the pooled allocators even if Unsafe can not be used.