Make JdkZlibEncoder accept Deflater.DEFAULT_COMPRESSION as level#15217
Merged
normanmaurer merged 1 commit intonetty:4.2from May 20, 2025
Merged
Make JdkZlibEncoder accept Deflater.DEFAULT_COMPRESSION as level#15217normanmaurer merged 1 commit intonetty:4.2from
normanmaurer merged 1 commit intonetty:4.2from
Conversation
Motivation: Right now the default compression level inside the used Deflater is defined as "-1", which according to zlib manual also defaults to "6" which is used inside netty as the default. That said, we should also allow to provide Deflater.DEFAULT_COMPRESSION (-1) as an argument. Modifications: The range check has been modified to allow for -1 and it now uses the constants instead of magic numbers. Small regression test added which just makes sure that no exception is thrown when provided. Result: Fixes netty#15212
normanmaurer
approved these changes
May 20, 2025
Member
|
@daschl thanks! |
normanmaurer
pushed a commit
that referenced
this pull request
May 20, 2025
) Motivation: Right now the default compression level inside the used Deflater is defined as "-1", which according to zlib manual also defaults to "6" which is used inside netty as the default. That said, we should also allow to provide Deflater.DEFAULT_COMPRESSION (-1) as an argument. Modifications: The range check has been modified to allow for -1 and it now uses the constants instead of magic numbers. Small regression test added which just makes sure that no exception is thrown when provided. Result: Fixes #15212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Right now the default compression level inside the used Deflater is defined as "-1", which according to zlib manual also defaults to "6" which is used inside netty as the default. That said, we should also allow to provide Deflater.DEFAULT_COMPRESSION (-1) as an argument.
Modifications:
The range check has been modified to allow for -1 and it now uses the constants instead of magic numbers. Small regression test added which just makes sure that no exception is thrown when provided.
Result:
Fixes #15212