Initialize DnsNameResolverBuilder at runtime for native images#14376
Merged
Initialize DnsNameResolverBuilder at runtime for native images#14376
DnsNameResolverBuilder at runtime for native images#14376Conversation
Motivation: After netty#14375 Netty/Testsuite/NativeImage/Client started to fail with: No instances of `java.net.Inet4Address` are allowed in the image heap as this class should be initialized at image runtime. Modifications: - Add `DnsNameResolverBuilder` to `native-image.properties`; Result: Netty/Testsuite/NativeImage/Client is expected to start working again.
chrisvest
approved these changes
Sep 27, 2024
Member
chrisvest
left a comment
There was a problem hiding this comment.
If the Graal build is happy, I'm happy.
chrisvest
pushed a commit
that referenced
this pull request
Sep 27, 2024
) Motivation: After #14375 Netty/Testsuite/NativeImage/Client started to fail with: No instances of `java.net.Inet4Address` are allowed in the image heap as this class should be initialized at image runtime. Modifications: - Add `DnsNameResolverBuilder` to `native-image.properties`; Result: Netty/Testsuite/NativeImage/Client is expected to start working again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
After #14375 Netty/Testsuite/NativeImage/Client started to fail with: No instances of
java.net.Inet4Addressare allowed in the image heap as this class should be initialized at image runtime.Modifications:
DnsNameResolverBuildertonative-image.properties;Result:
Netty/Testsuite/NativeImage/Client is expected to start working again.