chore: clean code DefaultChannelPipeline add method#14249
Merged
Conversation
Motivation: DefaultChannelPipeline has some duplicate code on there, it can be simplified using templates. Modification: The new `internalAdd`` method is used by `addFirst`, `addLast`, `addBefore` and `addAfter` Result: Clean code
Member
|
@Roiocam did you sign our ical ? https://netty.io/s/icla |
Contributor
Author
Yes, I found no format plugin, so I manually added a line break to fix the CI failed. |
Member
|
@chrisvest WDYT ? |
normanmaurer
approved these changes
Aug 28, 2024
Member
|
@Roiocam thanks! |
normanmaurer
pushed a commit
that referenced
this pull request
Aug 29, 2024
Motivation: DefaultChannelPipeline has some duplicate code on there, it can be simplified using templates Modification: The new `internalAdd` method is used by `addFirst`, `addLast`, `addBefore` and `addAfter` Result: Clean code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
DefaultChannelPipeline has some duplicate code on there, it can be simplified using templates
Modification:
The new
internalAddmethod is used byaddFirst,addLast,addBeforeandaddAfterResult:
Clean code