Add new SslHandler.isEncrypted(...) variant that will not produce fal…#14243
Merged
Conversation
…se-positives Motivation: SslHandler.isEncrypted(...) could produce false-positives as it might assumed that a buffer contained SSLv2. We should provide a variant of this method which is more robust Modifications: - Add new new variant of this method which allows to disable probing for SSLv2 - Add unit test Result: Fixes #14238
normanmaurer
commented
Aug 21, 2024
chrisvest
approved these changes
Aug 22, 2024
normanmaurer
added a commit
that referenced
this pull request
Aug 23, 2024
#14243) …se-positives Motivation: SslHandler.isEncrypted(...) could produce false-positives as it might assumed that a buffer contained SSLv2. We should provide a variant of this method which is more robust Modifications: - Add new new variant of this method which allows to disable probing for SSLv2 - Add unit test Result: Fixes #14238
normanmaurer
added a commit
that referenced
this pull request
Aug 23, 2024
#14243) …se-positives Motivation: SslHandler.isEncrypted(...) could produce false-positives as it might assumed that a buffer contained SSLv2. We should provide a variant of this method which is more robust Modifications: - Add new new variant of this method which allows to disable probing for SSLv2 - Add unit test Result: Fixes #14238
jfyuen
pushed a commit
to jfyuen/netty
that referenced
this pull request
May 5, 2025
netty#14243) …se-positives Motivation: SslHandler.isEncrypted(...) could produce false-positives as it might assumed that a buffer contained SSLv2. We should provide a variant of this method which is more robust Modifications: - Add new new variant of this method which allows to disable probing for SSLv2 - Add unit test Result: Fixes netty#14238 (cherry picked from commit dc30c33)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…se-positives
Motivation:
SslHandler.isEncrypted(...) could produce false-positives as it might assumed that a buffer contained SSLv2. We should provide a variant of this method which is more robust
Modifications:
Result:
Fixes #14238