Use the recommended directory layout for native-image metadata#12951
Merged
normanmaurer merged 1 commit intoNov 2, 2022
Merged
Conversation
Contributor
Author
|
Looking at the naming of the generated handler metadata folder, I think |
…ify automatic handler metadata generator usage.
b428fd6 to
c5058f9
Compare
normanmaurer
approved these changes
Nov 2, 2022
Member
|
Thanks a lot @gradinac |
Contributor
Author
|
Thank you very much for looking into this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The recommended directory layout for native-image metadata is
META-INF/native-image/<groupId>/<artifactId>/.... Recent Native Build Tools versions will print a warning if anative-image.propertiesfile is detected and it's path doesn't adhere to the above layout.Modification:
This PR moves all native-image related metadata so that it conforms to the above layout.
This PR also ensures the above layout is used for the automatically generated handler metadata. The new layout of this metadata is
META-INF/native-image/<groupId>/<artifactId>/automatic/handlers.Result:
Fixes #12934
I'll also create a Netty 5 PR with the similar changes