Merged
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
normanmaurer
requested changes
Aug 8, 2022
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
peternied
approved these changes
Aug 8, 2022
peternied
left a comment
There was a problem hiding this comment.
I agree with the comments about readability, but its a major improvement so other libraries/products don't have to do this themselves.
…f clause Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Author
|
@normanmaurer Thank you for the review. I have addressed the code review comments and moved this block: into the |
normanmaurer
requested changes
Aug 9, 2022
handler/src/main/java/io/netty/handler/ssl/util/BouncyCastlePemReader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
normanmaurer
approved these changes
Aug 10, 2022
normanmaurer
approved these changes
Aug 10, 2022
Member
|
@cwperks thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Aug 10, 2022
Motivation: Motivated by a stale [PR](#7451) that was closed. This change adds support for keys in the PKCS#1 format. Currently netty only supports PKCS#8 keys. Modification: This change introduces a class called `BouncyCastlePemReader` which is only used if BouncyCastle is available on the classpath and uses BouncyCastle's PEMParser to parse the private keys. See list of supported types [here](https://www.bouncycastle.org/docs/pkixdocs1.5on/org/bouncycastle/openssl/PEMParser.html). Tests are added in `SSLContextTest` including tests with PKCS#8 keys (encrypted + unencrypted) to show these working with BouncyCastle. Result: Fixes [#7323](#7323) Signed-off-by: Craig Perkins <cwperx@amazon.com>
This was referenced Sep 6, 2022
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins cwperx@amazon.com
Motivation:
Motivated by a stale PR that was closed. This change adds support for keys in the PKCS#1 format. Currently netty only supports PKCS#8 keys.
Modification:
This change introduces a class called
BouncyCastlePemReaderwhich is only used if BouncyCastle is available on the classpath and uses BouncyCastle's PEMParser to parse the private keys. See list of supported types here.Tests are added in
SSLContextTestincluding tests with PKCS#8 keys (encrypted + unencrypted) to show these working with BouncyCastle.Result:
Fixes #7323