Fix ObjectUtil message in HttpContentCompressor#11482
Merged
normanmaurer merged 1 commit intonetty:4.1from Jul 13, 2021
Merged
Conversation
Member
|
@hyperxpro thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jul 13, 2021
…11482) Motivation: In #11256, We introduced `Iterable` as a parameter but later in review, it was removed. But we forgot to change `compressionOptionsIterable` to just `compressionOptions`. Modification: Changed `compressionOptionsIterable` to `compressionOptions`. Result: Correct ObjectUtil message
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…etty#11482) Motivation: In netty#11256, We introduced `Iterable` as a parameter but later in review, it was removed. But we forgot to change `compressionOptionsIterable` to just `compressionOptions`. Modification: Changed `compressionOptionsIterable` to `compressionOptions`. Result: Correct ObjectUtil message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In #11256, We introduced
Iterableas a parameter but later in review, it was removed. But we forgot to changecompressionOptionsIterableto justcompressionOptions.Modification:
Changed
compressionOptionsIterabletocompressionOptions.Result:
Correct ObjectUtil message