Revert "Enable SSL_MODE_ENABLE_FALSE_START if jdkCompatibilityMode is… #10980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false (#10407)" Motivation: TLS_FALSE_START slightly changes the "flow" during handshake which may cause suprises for the end-user. We should better disable it by default again and later add a way to enable it for the user. Modification: This reverts commit 514d349. Result: Restore "old flow" during TLS handshakes.
Scottmitch
approved these changes
Jan 29, 2021
normanmaurer
added a commit
that referenced
this pull request
Jan 29, 2021
… false (#10407)" (#10980) Motivation: TLS_FALSE_START slightly changes the "flow" during handshake which may cause suprises for the end-user. We should better disable it by default again and later add a way to enable it for the user. Modification: This reverts commit 514d349. Result: Restore "old flow" during TLS handshakes.
Member
|
Late LGTM, thanks! |
1 task
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
… false (netty#10407)" (netty#10980) Motivation: TLS_FALSE_START slightly changes the "flow" during handshake which may cause suprises for the end-user. We should better disable it by default again and later add a way to enable it for the user. Modification: This reverts commit 514d349. Result: Restore "old flow" during TLS handshakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… false (#10407)"
Motivation:
TLS_FALSE_START slightly changes the "flow" during handshake which may cause suprises for the end-user. We should better disable it by default again and later add a way to enable it for the user.
Modification:
This reverts commit 514d349.
Result:
Restore "old flow" during TLS handshakes.