Skip to content

Revert "Support session cache for client and server when using native…#10528

Merged
normanmaurer merged 1 commit into4.1from
revert_ssl_session
Sep 3, 2020
Merged

Revert "Support session cache for client and server when using native…#10528
normanmaurer merged 1 commit into4.1from
revert_ssl_session

Conversation

@normanmaurer
Copy link
Copy Markdown
Member

… SSLEngine implementation (#10331)"

Motivation:

This reverts commit 825916c as it turns out it introduced a big performance regression.

Modifications:

Revert 825916c

Result:

Performance of TLS is back to normal

… SSLEngine implementation (#10331)"

Motivation:

This reverts commit 825916c as it turns out it introduced a big performance regression.

Modifications:

Revert 825916c

Result:

Performance of TLS is back to normal
@hyperxpro
Copy link
Copy Markdown
Contributor

Out of curiosity, tests have been failing a lot with connection timeout errors these days. Does the CI have network connectivity issues?

01:27:35 [ERROR]     Unresolveable build extension: Plugin kr.motd.maven:os-maven-plugin:1.6.2 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.commons:commons-lang3:jar:3.5 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar: Connect to repo.maven.apache.org:443 [repo.maven.apache.org/151.101.188.215] failed: Connection timed out -> [Help 2]

Copy link
Copy Markdown
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@normanmaurer
Copy link
Copy Markdown
Member Author

@hyperxpro its running on AWS :/

@normanmaurer normanmaurer merged commit 5157d3b into 4.1 Sep 3, 2020
@normanmaurer normanmaurer deleted the revert_ssl_session branch September 3, 2020 06:32
@normanmaurer normanmaurer added this to the 4.1.52.Final milestone Sep 3, 2020
normanmaurer added a commit that referenced this pull request Oct 2, 2020
…g native SSLEngine implementation (#10331)" (#10528)"

This reverts commit 5157d3b.
normanmaurer added a commit that referenced this pull request Oct 14, 2020
…g native SSLEngine implementation (#10331)" (#10528)"

This reverts commit 5157d3b.
normanmaurer added a commit that referenced this pull request Feb 2, 2021
…g native SSLEngine implementation (#10331)" (#10528)"

This reverts commit 5157d3b.
normanmaurer added a commit that referenced this pull request Feb 11, 2021
…g native SSLEngine implementation (#10331)" (#10528)"

This reverts commit 5157d3b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants