Dumper: scrubber checks also non-string keys #473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Tracy support for scrubbing to remove passwords etc. from our Tracy bluescreen files. But we've found that in following part of stacktrace (in
Elasticsearch\Transportfrom official Elasticsearch SDK), password remained:It's because
Describerdoesn't apply scrubber on non-string keys. This PR argues that they have to be for sanity checked as well. I've chosen the path of not changing Scrubber signature, so I cast scalar keys to strings and pass empty string for non scalar keys. To be honest I am not sure whether such eventuality is possible (I was thinking aboutWeakMapand stuff like that, but not sure if it would make its way there).