Assert::isEqual: can compare recursive objects [Closes #93] #99
Conversation
Tester/Framework/Assert.php
Outdated
There was a problem hiding this comment.
are you sure about this one? I think there should be &&
There was a problem hiding this comment.
I don't know, I just woke up and it looks weird :)
There was a problem hiding this comment.
Wouldn't there be the path problem that milo tried to solve?
|
@milo any objections? |
|
Nice and elegant! I had to sit and draw it on paper :) Comments in code. |
Tester/Framework/Assert.php
Outdated
There was a problem hiding this comment.
Maybe shorter:
if (isset($checked[$expected])) {
return $checked[$expected] === $actual;
} elseif (isset($checked[$actual])) {
return FALSE;
} elseif ($expected === $actual) {
return TRUE;
}Btw. second elseif seems logically, but test passes without it too. It just returns FALSE on next level.
There was a problem hiding this comment.
Yes, in this case the second if is unnecessary, because $expected !== $actual. Repushed.
Now it is really very simple implementation ;-)
|
Great. I would merge it soon if no one complains. |
|
👍 |
Assert::isEqual: can compare recursive objects [Closes #93]
|
👏 |
No description provided.