Skip to content

Remove NULL byte from class names, which cause problems when using phpdbg #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smuuf wants to merge 1 commit into from
Closed

Remove NULL byte from class names, which cause problems when using phpdbg #450

smuuf wants to merge 1 commit into from

Conversation

@smuuf
Copy link
Contributor

@smuuf smuuf commented Jun 12, 2024 •
edited
Loading

Resolves #449

  • bug fix
  • BC break? no (hopefully)

New output, which is now correct (from what is described in the issue):

[smuuf@smuuf-hp]$ phpdbg8.2 -qrrb -d memory_limit=4096M -d register_argc_argv=on anonclasstestcase.phpt --method=nette-tester-list-methods

TestCase:Tester\TestCase@anonymous/mnt/d/produkce/coding/php/php-nette-tester/anonclasstestcase.phpt:8$0
Method:testMe
Dependency:/mnt/d/produkce/coding/php/php-nette-tester/anonclasstestcase.phpt
Dependency:/mnt/d/produkce/coding/php/php-nette-tester/src/Framework/TestCase.php

[smuuf@smuuf-hp]$ php8.2 -d memory_limit=4096M -d register_argc_argv=on anonclasstestcase.phpt --method=nette-tester-list-methods

TestCase:Tester\TestCase@anonymous/mnt/d/produkce/coding/php/php-nette-tester/anonclasstestcase.phpt:8$0
Method:testMe
Dependency:/mnt/d/produkce/coding/php/php-nette-tester/anonclasstestcase.phpt
Dependency:/mnt/d/produkce/coding/php/php-nette-tester/src/Framework/TestCase.php

@dg dg force-pushed the master branch 2 times, most recently from 15c0cd0 to 9f3ba77 Compare June 18, 2024 16:49
@dg dg closed this in 9fd36f8 Jun 18, 2024
@dg
Copy link
Member

dg commented Jun 18, 2024

Thanks

dg added a commit that referenced this pull request Jun 18, 2024
@dg
TestCase: removed NULL byte from class names, thx @smuuf [Closes #450][…
027bd0a 
…Closes #449]

get_debug_type() does not output a null byte for anonymous classes
@smuuf smuuf deleted the fixanonclasses branch September 25, 2024 07:36
@jorgsowa jorgsowa mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestCase doesn't report test methods correctly when using phpdbg

2 participants

@smuuf @dg