Skip to content

Conversation

@milo
Copy link
Member

@milo milo commented Nov 26, 2017

  • bug fix? no
  • new feature? yes
  • BC break? no
  • doc PR: no needed

This PR tries to solve #369 as follows.

Output of test method listing is now in format:

$ php tests/Framework/Assert.equal.recursive.phpt --method=nette-tester-list-methods

TestCase:RecursionTest
Method:testSimple
Method:testMultiple
Method:testDeep
Method:testCross
Method:testThirdParty
Dependency:D:\Web\dev\nette\tester\tests\Framework\Assert.equal.recursive.phpt
Dependency:D:\Web\dev\nette\tester\src\Framework\TestCase.php

The TestCase:... line is here only for check, that TestCase::run() method is run.

The Method:... lines are test methods, formerly as [testSimple,testMultiple,...].

The Dependency:... lines are new. It is a list of declaring files. TestCase class, all its parents and all traits. With such information the TestHandler can keep cache.

@milo milo force-pushed the testcase-list-cache branch from 029ae4f to 87153e4 Compare November 26, 2017 21:38
@milo
Copy link
Member Author

milo commented Nov 26, 2017

@JanTvrdik Could you please test impact on speed?

@milo milo mentioned this pull request May 30, 2018
@milo milo force-pushed the testcase-list-cache branch from 87153e4 to f186423 Compare May 30, 2018 11:22
milo added a commit to milo/tester that referenced this pull request May 30, 2018
milo added a commit to milo/tester that referenced this pull request May 30, 2018
milo added a commit to milo/tester that referenced this pull request May 30, 2018
@milo milo force-pushed the master branch 2 times, most recently from 25957cd to fd8929c Compare May 30, 2018 11:29
@milo milo force-pushed the testcase-list-cache branch from f186423 to 27491e3 Compare May 30, 2018 11:36
milo added a commit to milo/tester that referenced this pull request May 30, 2018
milo added a commit to milo/tester that referenced this pull request May 30, 2018
milo added a commit to milo/tester that referenced this pull request May 30, 2018
@milo
Copy link
Member Author

milo commented May 30, 2018

@JanTvrdik @matej21 Could you please test this branch? We would like to release 2.1 soon and this is a candidate for merge.

@dg dg force-pushed the master branch 2 times, most recently from b9711f5 to 3f273cf Compare June 7, 2018 11:24
@milo milo force-pushed the testcase-list-cache branch from 27491e3 to 33c80b3 Compare June 12, 2018 10:54
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
@milo milo force-pushed the testcase-list-cache branch from 33c80b3 to 3d31fdc Compare June 12, 2018 10:56
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
milo added a commit to milo/tester that referenced this pull request Jun 12, 2018
@milo milo force-pushed the master branch 2 times, most recently from eaaeb7b to 7184606 Compare February 21, 2019 06:47
@milo milo force-pushed the testcase-list-cache branch from e74c7b9 to 840f1d7 Compare January 2, 2021 22:56
@milo milo force-pushed the testcase-list-cache branch from 840f1d7 to f980cdc Compare January 2, 2021 23:02
@milo milo merged commit f980cdc into nette:master Jan 2, 2021
milo added a commit that referenced this pull request Jan 3, 2021
dg pushed a commit that referenced this pull request Jan 31, 2021
dg pushed a commit that referenced this pull request Jan 31, 2021
dg pushed a commit that referenced this pull request Feb 5, 2021
dg pushed a commit that referenced this pull request Mar 1, 2021
dg pushed a commit that referenced this pull request Mar 1, 2021
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo milo deleted the testcase-list-cache branch July 21, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant