run tearDown() if TestCase fails with PHP error [closes #254] #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f84e3f to
016d854
Compare
src/Framework/TestCase.php
Outdated
Member
There was a problem hiding this comment.
Restore handler here to prevent recursion.
src/Framework/TestCase.php
Outdated
Member
There was a problem hiding this comment.
Name it as _tearDown() and fix coding style. Double empty line between methods, one empty line after the last one, curly bracket on separated line.
Member
|
What about /** @internal */
public function _errorHandler()
{
restore_error_handler();
@$this->tearDown(); // ignore, error from testMethod() has higher precedence
return $this->previousHandler
? call_user_func_array($this->previousHandler, func_get_args())
: FALSE;
} |
milo
added a commit
to milo/tester
that referenced
this pull request
Oct 9, 2015
milo
added a commit
to milo/tester
that referenced
this pull request
Oct 9, 2015
milo
added a commit
to milo/tester
that referenced
this pull request
Oct 9, 2015
Contributor
Author
|
@milo thanks for suggestion, I like your _errorHandler alternative :) fixed in my code |
Member
|
Solved by d25b672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.