Skip to content

Conversation

@Mikulas
Copy link
Contributor

@Mikulas Mikulas commented Aug 6, 2015

  • Fixed bug that caused (empty) coverage to be generated even for --method=nette-tester-list-methods, improving startup time for codebases with a lot of test cases
  • Reduced blocking time of coverage to 3 % of original. (merged in 9b62462)

Collector benchmark:

original blocking: 74.48 ms

     new prepared: 71.04 ms
     new blocking:  2.35 ms
          new sum: 73.38 ms

@Mikulas Mikulas force-pushed the coverage-optimizations branch from 45f035b to a763d9f Compare August 6, 2015 13:35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARRAY_FILTER_USE_KEY exists since PHP 5.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, that part is not needed anyway. I'll rebase.

@Mikulas Mikulas force-pushed the coverage-optimizations branch from a763d9f to b9503ab Compare August 6, 2015 14:21
@milo
Copy link
Member

milo commented Aug 10, 2015

What about not to set Environment::COVERAGE in initial phase?

@Mikulas
Copy link
Contributor Author

Mikulas commented Aug 10, 2015

I've looked into that but it seemed it would require a lot of refactoring, which I deemed unnecessary.

Fix array_replace_recursive merging to null
@Mikulas
Copy link
Contributor Author

Mikulas commented Feb 12, 2016

This was partially incorporated by 9b62462 .


bug that caused (empty) coverage to be generated even for --method=nette-tester-list-methods

still needs to be fixed though.

@milo
Copy link
Member

milo commented May 19, 2016

@Mikulas Do you think that something from this PR is needed after 1b583e9?

@Mikulas
Copy link
Contributor Author

Mikulas commented May 19, 2016

I believe everything from this PR was merged. Thanks :)

@Mikulas Mikulas closed this May 19, 2016
@Mikulas Mikulas deleted the coverage-optimizations branch May 19, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants