Prevent classes and methods from declared both final and abstract #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al and abstract [BC break]
Member
|
It's probably better to check it when the code is generated, to allow this anytime: $class->setAbstract(true)->setFinal(false);ie. in cases when $class is already marked as final |
dg
pushed a commit
that referenced
this pull request
Aug 29, 2018
…m declared both final and abstract [BC break] (#36)
dg
pushed a commit
that referenced
this pull request
Aug 29, 2018
…m declared both final and abstract [BC break] (#36)
dg
pushed a commit
that referenced
this pull request
Aug 29, 2018
…m declared both final and abstract [BC break] (#36)
dg
pushed a commit
that referenced
this pull request
Aug 29, 2018
…m declared both final and abstract [BC break] (#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes and methods cannot be declared final and abstract. This will now throw an exception if you try to generate a final abstract class or method. It's a BC break because of the new exception, but the generated code would never have been valid, so I doubt there is any use that will break