DI: blacklist of classes excluded from autowiring #1424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I really like the idea, not so much the actual implementation. |
Contributor
Author
|
@JanTvrdik: Can you be more specific? |
Contributor
Author
|
cc @dg |
dg
pushed a commit
to nette/di
that referenced
this pull request
Jun 24, 2014
dg
pushed a commit
to nette/di
that referenced
this pull request
Aug 11, 2014
dg
pushed a commit
to nette/di
that referenced
this pull request
Aug 27, 2014
dg
pushed a commit
to nette/di
that referenced
this pull request
Aug 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents from autowiring generic typehints like IContainer.
example: You have some component (in my case it was visual paginator) and factory interface. You register that factory in DI container. Then you register some presenter in DI container. Because VisualPaginator has constructor from ComponentModel\Component (
__construct(IContainer $parent = NULL...), nette tries to autowire presenter. And this may cause serious problems. This PR excludes Component, Container etc. from autowiring. Of course, you still can autowire all descendants which are not blacklisted. (so you cannot autowire UI\Presenter but you can autowire FooPresenter)As a side effect, this PR shrinks down the size of generated container :)