[WIP] PhpGenerator: Added support for variadics (PHP 5.6 feature) #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Contributor
|
👍 |
Member
|
setVariadic() for Parameter seems unnecessary, in the case of PHP generator. |
Contributor
|
@dg: I think it could be used in generated factories (in the case there will be support for variadics in generated factories :)) |
Member
|
@matej21 Method::setVariadic() is ok, just Parameter::setVariadic() seems unnecessary. |
dg
pushed a commit
that referenced
this pull request
Mar 15, 2014
dg
pushed a commit
that referenced
this pull request
Mar 17, 2014
dg
pushed a commit
that referenced
this pull request
Mar 17, 2014
dg
pushed a commit
to nette/php-generator
that referenced
this pull request
Mar 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for variadics which will arrive with 5.6.