Database: SqlBuilder: added support for REGEXP and RLIKE operators in WHERE #1156
Conversation
There was a problem hiding this comment.
You can notice that the keywords should be ordered alphabetically. Fix it please. ;-)
There was a problem hiding this comment.
Were they? Was "OR" before "NOT"? ;)
There was a problem hiding this comment.
Well I think that is a typo.
There was a problem hiding this comment.
It just a coincidence, but RLIKE is redundant, because LIKE is already present (it its suffix).
There was a problem hiding this comment.
@hrach: no, it is not redundant:
-- with RLIKE in the list:
WHERE `col` RLIKE 'foo'
-- without:
WHERE `col` RLIKE = 'foo'There was a problem hiding this comment.
@hrach: Only if the assertion (?<=\W|^) wasn't there.
There was a problem hiding this comment.
hmhm, so in that case also xor, etc missing too :)
There was a problem hiding this comment.
Oh yes, this commit broken my initial idea. 53813ce
Database\Table\SqlBuilder: added suffix test, added missing RLIKE & REGEXP operator [closes #1156]
…EGEXP operator [closes nette/nette#1156]
No description provided.