POST data overwrite persistent parameters. #1061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lines are redundant in my opinion. When I send data from AJAX form, I lost persistent data with the same name as form-input name.
Contributor
|
No, you do not. Provide test case. |
Contributor
Author
|
Sorry, you are right. If current value is NULL (or default), it changes persistent parameter. But problem with rewriting value is still here. I don't understand the meaning of these lines. In which case can I use this 'feature'? |
Contributor
|
👎 This would break almost every application using AJAX. |
Member
|
From my point of view, there is no difference between GET and POST AJAX request. |
991ba1a to
e23de7a
Compare
dg
added a commit
to dg/nette-application
that referenced
this pull request
Apr 1, 2016
dg
added a commit
to dg/nette-application
that referenced
this pull request
Apr 1, 2016
dg
added a commit
to dg/nette-application
that referenced
this pull request
Apr 1, 2016
dg
added a commit
to dg/nette-application
that referenced
this pull request
Apr 16, 2016
dg
added a commit
to nette/application
that referenced
this pull request
Apr 30, 2016
dg
added a commit
to nette/application
that referenced
this pull request
Apr 30, 2016
dg
added a commit
to nette/application
that referenced
this pull request
Apr 30, 2016
dg
added a commit
to nette/application
that referenced
this pull request
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines are redundant in my opinion. When I send data from AJAX form, I lost persistent data with the same name as form-input name.