CachingIterator: do not ask when not in valid state #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test failures seems unrelated. |
63d6779 to
31553c2
Compare
Contributor
Author
|
@dg what do you think? |
f6d1b05 to
2a1d768
Compare
dg
pushed a commit
that referenced
this pull request
Nov 3, 2020
dg
pushed a commit
that referenced
this pull request
Nov 3, 2020
dg
pushed a commit
that referenced
this pull request
Nov 3, 2020
dg
pushed a commit
that referenced
this pull request
Nov 4, 2020
dg
pushed a commit
that referenced
this pull request
Nov 4, 2020
dg
pushed a commit
that referenced
this pull request
Nov 4, 2020
dg
pushed a commit
that referenced
this pull request
Nov 4, 2020
dg
pushed a commit
that referenced
this pull request
Nov 4, 2020
dg
pushed a commit
that referenced
this pull request
Nov 5, 2020
dg
pushed a commit
that referenced
this pull request
Nov 6, 2020
dg
pushed a commit
that referenced
this pull request
Nov 7, 2020
dg
pushed a commit
that referenced
this pull request
Nov 7, 2020
dg
pushed a commit
that referenced
this pull request
Nov 7, 2020
dg
pushed a commit
that referenced
this pull request
Nov 7, 2020
dg
pushed a commit
that referenced
this pull request
Nov 8, 2020
dg
pushed a commit
that referenced
this pull request
Nov 8, 2020
dg
pushed a commit
that referenced
this pull request
Nov 8, 2020
dg
pushed a commit
that referenced
this pull request
Nov 10, 2020
dg
pushed a commit
that referenced
this pull request
Nov 10, 2020
dg
pushed a commit
that referenced
this pull request
Nov 10, 2020
dg
pushed a commit
that referenced
this pull request
Nov 11, 2020
dg
pushed a commit
that referenced
this pull request
Nov 11, 2020
dg
pushed a commit
that referenced
this pull request
Nov 12, 2020
dg
pushed a commit
that referenced
this pull request
Nov 12, 2020
dg
pushed a commit
that referenced
this pull request
Nov 14, 2020
dg
pushed a commit
that referenced
this pull request
Nov 15, 2020
dg
pushed a commit
that referenced
this pull request
Nov 15, 2020
dg
pushed a commit
that referenced
this pull request
Nov 15, 2020
dg
pushed a commit
that referenced
this pull request
Nov 15, 2020
dg
pushed a commit
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner iterator is one iteration ahead and therefore when CachingIterator asks for the next value (key), it uses a current() method on the inner iterator. But the iteration may have finished and calling iterator's current() and key() in invalid state may produce an exception or invalid data.
PHP'S internal ArrayIterator returns a null, but generally speaking the iterators should rather throw. When doing types properly, we can't even type such interface.
This PR asks first if the inner iterator is in a valid state.