Skip to content

SessionExtension: added option handler to pass own SessionHandlerInterface #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Nov 23, 2018
Merged

SessionExtension: added option handler to pass own SessionHandlerInterface #146

dg merged 1 commit into from
Nov 23, 2018

Conversation

@milo
Copy link
Member

@milo milo commented Nov 23, 2018

  • new feature
  • BC break? no

Own session handler cannot be set via session.save_handler, the ini_set() accepts string type only.
Can be solved by decorator extension:

decorator:
    Nette\Http\Session:
        setup:
            - setHandler(...)

but propesed way seems more suitable to me.

@dg
Copy link
Member

dg commented Nov 23, 2018

Thanks

@dg dg merged commit 0d9bfaf into nette:master Nov 23, 2018
dg pushed a commit that referenced this pull request Nov 23, 2018
@milo @dg
SessionExtension: added option handler to pass own SessionHandlerInte…
980b18f 
…rface (#146)
dg pushed a commit that referenced this pull request Nov 23, 2018
@milo @dg
SessionExtension: added option handler to pass own SessionHandlerInte…
f1f8dad 
…rface (#146)
dg pushed a commit that referenced this pull request Nov 23, 2018
@milo @dg
SessionExtension: added option handler to pass own SessionHandlerInte…
fe9a87f 
…rface (#146)
@milo
Copy link
Member Author

milo commented Nov 30, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milo @dg