Take session ID from session_id() instead of cookie. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes lost session when session ID is regenerated and then restarted.
Author
|
AppVeyor fail is not related to this PR. |
dg
reviewed
Mar 14, 2018
| session_id($id); | ||
| } else { | ||
| unset($_COOKIE[session_name()]); | ||
| $id = session_id(); |
Member
There was a problem hiding this comment.
I tested it and it returns empty string when session is not started.
dg
added a commit
that referenced
this pull request
Mar 14, 2018
dg
added a commit
that referenced
this pull request
Mar 14, 2018
dg
added a commit
that referenced
this pull request
Mar 14, 2018
dg
added a commit
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
Session ID is taken from
session_id()instead of cookie.