Add fluent setter and getter for checkAllowedValues #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
Contributor
Author
|
any suggestion? I mean variable name is checkAllowedValues, so I just added set before... |
Contributor
|
How about |
Member
|
Sounds good. Although it sounds that values are checked by calling that method. |
|
|
Contributor
Author
|
Better now? |
Contributor
|
@PavelJurasek I think about the same, but with parameter name |
8ed13d7 to
d6aa86e
Compare
1c0b101 to
2e462fb
Compare
dg
pushed a commit
that referenced
this pull request
Sep 8, 2017
…cement for $checkAllowedValues (#151)
dg
pushed a commit
that referenced
this pull request
Sep 8, 2017
…cement for $checkAllowedValues (#151)
dg
pushed a commit
that referenced
this pull request
Sep 8, 2017
…cement for $checkAllowedValues (#151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for not following template, but I believe everything is preety clear here.
I run into this one on project I'm working on and IMHO checkAllowedValues shouldn't be just field but property with fluent setter. It's also more consistent like that and easier to add.
I wished to set it as private as well but that would be breaking change...